Load extensions from DevTools server instead of using stubs. #6097
Conversation
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/extensions/extension_service.dart
Outdated
Show resolved
Hide resolved
| var fileUri = await serviceManager.rootLibraryForSelectedIsolate(); | ||
| if (fileUri == null) return null; | ||
|
|
||
| if (fileUri.endsWith('/lib/main.dart')) { |
There was a problem hiding this comment.
What happens if the root library isn't main.dart? There's no requirement for the entry point of a Dart or Flutter program to be in main.dart. I'm not even sure there's a requirement for it to be in a library of the form lib/<script> for Flutter, but there definitely isn't for Dart programs.
There was a problem hiding this comment.
Is there a convention for finding the root directory that contains the .dart_tool folder? Is this guaranteed to always be the parent of lib/?
There was a problem hiding this comment.
I'm not sure, especially if you don't have access to the FS. If you did, you'd just walk the directory chain until you found the directory containing .dart_tool.
I think you're probably safe to assume that the entrypoint is under lib/, so if you update this to fileUri.endsWith(RegExp(r'\/lib\/[^\/.]*.dart')) this should work the vast majority of the time.
There was a problem hiding this comment.
Optionally, I could just pass the whole root library to the server and have the server look for the .dart_tool folder?
There was a problem hiding this comment.
That'd be the most accurate way of handling it.
There was a problem hiding this comment.
Used the regexp for now but added a todo to move this logic to the server.
packages/devtools_shared/lib/src/extensions/extension_model.dart
Outdated
Show resolved
Hide resolved
packages/devtools_shared/lib/src/extensions/extension_model.dart
Outdated
Show resolved
Hide resolved
#6094 needs to land first before this can land.
Work towards #1632